Visual Scripting - Crash Deleting Output Parameter

Visual Scripting Tool crashes when removing a parameter from an Output node in some circumstances. This crash is reproducible with more than one script.

Steps to Reproduce

• Add a parameter to the Output node
• Connect the new parameter to the Constant node
• Double click on the out parameter to remove it
• VST crashes with the following stack traces:

2020-08-05 12:37:56.076 - Thread: 1 -> Error: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.

at System.ThrowHelper.ThrowKeyNotFoundException()

at System.Collections.Generic.Dictionary`2.get_Item(TKey key)

at VisualScriptingPlugin.Nodes.MyScriptNodeOutputInteraction.WriteConnectionData(NodeConnection connection, Boolean reset)

at VisualScriptingPlugin.WindowScriptEditor.graphControl_workspace_ConnectionRemoved(Object sender, NodeConnectionEventArgs e)

at GraphWPF.GraphControlWPF.Disconnect(NodeConnection connection, Boolean updateCache)

at VisualScriptingPlugin.Nodes.MyScriptNodeOutputInteraction.RemoveParam(String name)

at VisualScriptingPlugin.Nodes.MyScriptNodeOutputInteraction.ParamOnDoubleClicked(Object o, NodeItemEventArgs nodeItemEventArgs)

at GraphWPF.NodeItem.OnDoubleClick(Point& cursorTransformedLocation)

at GraphWPF.GraphControlWPF.OnMouseDoubleClick(MouseButtonEventArgs e)

at System.Windows.Controls.Control.HandleDoubleClick(Object sender, MouseButtonEventArgs e)

at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)

at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)

at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)

at System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)

at System.Windows.UIElement.OnMouseDownThunk(Object sender, MouseButtonEventArgs e)

at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)

at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)

at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)

at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)

at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)

at System.Windows.Input.InputManager.ProcessStagingArea()

at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)

at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)

at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)

at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)

at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)

at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)

at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(DispatcherPriority priority, TimeSpan timeout, Delegate method, Object args, Int32 numArgs)

at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam)

at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)

at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(IntPtr dwComponentID, Int32 reason, Int32 pvLoopData)

at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)

at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)

at VRageEditor.VRageEditor.OnTick()

at Sandbox.Engine.Platform.FixedLoop.<>c__DisplayClass11_0.<Run>b__0()

at Sandbox.Engine.Platform.GenericLoop.Run(VoidAction tickCallback)

at VRageEditor.VRageEditor.Run()

2020-08-05 12:37:58.233 - Thread: 1 -> Error: System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.

at System.ThrowHelper.ThrowKeyNotFoundException()

at System.Collections.Generic.Dictionary`2.get_Item(TKey key)

at VisualScriptingPlugin.Nodes.MyScriptNodeOutputInteraction.WriteConnectionData(NodeConnection connection, Boolean reset)

at VisualScriptingPlugin.WindowScriptEditor.graphControl_workspace_ConnectionRemoved(Object sender, NodeConnectionEventArgs e)

at GraphWPF.GraphControlWPF.Disconnect(NodeConnection connection, Boolean updateCache)

at VisualScriptingPlugin.Nodes.MyScriptNodeOutputInteraction.RemoveParam(String name)

at VisualScriptingPlugin.Nodes.MyScriptNodeOutputInteraction.ParamOnDoubleClicked(Object o, NodeItemEventArgs nodeItemEventArgs)

at GraphWPF.NodeItem.OnDoubleClick(Point& cursorTransformedLocation)

at GraphWPF.GraphControlWPF.OnMouseDoubleClick(MouseButtonEventArgs e)

at System.Windows.Controls.Control.HandleDoubleClick(Object send