This object is in archive! 

DLC

AccidentallyTheCable shared this bug 5 years ago
Won't Fix

Replies (5)

photo
1

Hello,


Could you please provide us with more information regarding the issue you reported? To report a bug into our system it is necessary to have reliable steps to reproduce in order for programmers to fix it.


Any additional information would be greatly appreciated!


Thank you.


Kind Regards

Keen Software House: QA Department

photo
1

NullReferenceException is thrown when in the G menu and certain mods are present. As an example, Armoured Conveyors crashes to desktop when clicking on the Cargo/Conveyors section in G.


Looking at the log, the last line to be called was GetDefinitionDLC. In which a null ref was through. I am unable to decompile that class to see what could be missing in the definition, but Looking at the XML, nothing seems to be in error. Unless some tags have been removed from the schema or renamed?


Any comments on this?


Has the definition schema changed at all since the DLC update (excluding the new DLC tag)?

photo
1

Another example for you to use.


https://steamcommunity.com/sharedfiles/filedetails/?id=1639529022 <-- link to mod affected.


Same scenario, when you click on the sub menu within the G Menu you get a crash to desktop, when you search for one of the blocks rather than going to the sub menu then you can use the blocks.


This is just one example of a large section of mods that are affected by this issue. and they all have the GetDefinitionDLC in the error. Is there something else we need to be putting into any of the mod files to get them to work once more ?


This is offline and online, tested using someone who has paid for DLC and someone who has not.

photo
1

the second guy that was testing with gavin


heres another example, you will find log file attached, all of these mods were working before the lcd/dlc release, but now. when hovering over the categorys you get a ctd (refrencing the DLC)

photo
1

The issue appears to be references appearing in the definition files that dont exist.


For example, in Armour Conveyors, there were BlockVariants with a reference to a none-existent block in them.


Removing any reference to non-existent blocks fixes the issue.


This is something the mod owners will need to do, unless Keen allow ignoring of that error in the failing method.


In you case @James Bundy, the particular definition that is missing is:

2_Glass_Base_IR from the U_Window_IR pack.


I know some fixes to some mods are already in place though. Only a matter of time i think.

photo
1

this is the thing thou, before the update, fine 0 errors to do with definitions in the mod, after update however, its started, and pretty sure if the definitions aren't working you wont be bale to place the block ingame? but yet we are via the seach menu


if this is infact intentional becuase keen have changed something, then wheres the documentaion saying this?

photo
1

Would it also call error if the block that has variants calls on itself as a variant if you get what I mean ?

photo
1

Im not sure about the cyclic reference to be honest. But im not sure it will as it will only be looking for the one variant and doesnt check the variants of said variant... Confusing statements abound.

photo
1

@James, It just seems that the new DLC code is not as robust as the current code when it comes to handling missing references.


I doubt there was any intention to introduce this bug, just an oversight on guarding for mistakes in mods... If the mod is correct, there is no error.


A reference to a non-existent block is an error, but Keen obviously accounted for that before (intentionally or accidentally)

photo
1

Yeah, the question is if this intended or not, if it is infact a bug then hopefully it will get resolved and they will improve on the dlc code, which tbh... its one line to make it free for players. (deffintly needs securing better)

photo
1

@Stuart Ok taking your advice I have a mod I was playing with as a test … found two references to something that wasn't there and also 1 cyclic reference, will test once I can get on my home PC and report back

photo
1

Is this something you wrote yourself or amended from the workshop?


Some references may be to existing Keen assets but not in the CubeBlocks file for the mod.


But so far most things have pointed to this reference thing.

photo
1

Looks like the last patch fixed it , but it has made me aware of some messy lines in the cubeblocks that I was blissfully unaware of before I must admit … time to tidy some shizz :) Thanks for your help Stuart and Thanks to Keen for fixing

photo
1

Hello, Engineers,

as it´s quite some time from submitting this thread as well as from last comment, I need to ask if you are still experiencing this issue. Can you confirm it is no longer happening?

Thanks for the info.

Kind Regards

Keen Software House: QA Department

photo
1

Hello, Engineers!


Because there is no new comment from you, and we are unable to reproduce the issue on our own, I will close this thread now as outdated.


If you or any other player will experience this issue again, please make a new thread and provide all needed info there.


Thank you for understanding.


Kind Regards


Keen Software House: QA Department

Replies have been locked on this page!