Mod-added ships in economy stores don't have icons
Pretty much all mods that add prefabs will not get their icons working in the store blocks because the definition isn't fully loaded when those icons are being added to the ImageManager.
STR:
1. Create a new star system world with this mod present: https://steamcommunity.com/sharedfiles/filedetails/?id=3317449166
2. Find a trader station that sells ships.
3. Open the store block GUI to see things for sales, the ships will not have icons.
This is seemingly random because it relies on the prefab definition being fully initialized in order to have the icon paths even looked at in MySession.CacheGuiTexturePaths().
Note that reading definition's CubeGrids/etc would initialize it and no longer have Icons be null, so depending on how one uses a debugger it can fix the issue and/or send you on wild goose chases.
The proper fix probably involves initializing the present prefabs when opening the store GUI and then calling ImageManager.Instance.AddImage() for those particular ones.
Replies have been locked on this page!