Custom Contracts API broken behavior

I believe Keen made some gestures in 2022 to make the game more modder friendly... especially working with modders. This is, again, one of those situations. Here's a feature that should have better hooks in the API since NPC faction disposition factors into any modded game or SCENARIO with NPCs. Completing a modded task or quest for the NPC as well as query the disposition allows for better world building.

This is very important for new content. It should be on the list.

Here is a code for loading localization:

private void LoadLocalization(string folder) {
 var path = Path.Combine(ModContext.ModPathData, folder);
 var supportedLanguages = new HashSet<MyLanguagesEnum>();
 MyTexts.LoadSupportedLanguages(path, supportedLanguages);

 var currentLanguage = supportedLanguages.Contains(MyAPIGateway.Session.Config.Language) ? MyAPIGateway.Session.Config.Language : MyLanguagesEnum.English;
 if (Language != null && Language == currentLanguage) {
 return;
 }

 Language = currentLanguage;
 var languageDescription = MyTexts.Languages.Where(x => x.Key == currentLanguage).Select(x => x.Value).FirstOrDefault();
 if (languageDescription != null) {
 var cultureName = string.IsNullOrWhiteSpace(languageDescription.CultureName) ? null : languageDescription.CultureName;
 var subcultureName = string.IsNullOrWhiteSpace(languageDescription.SubcultureName) ? null : languageDescription.SubcultureName;
 MyTexts.LoadTexts(path, cultureName, subcultureName);
 }
}

Yes its i wanted feature ! Pls if we can fix it that would be great !

I love this mod idea and it would be great if the API could be fixed so it worked with economy stations

Hello Patrick Heney,

Localization works fine.

You need translate "ContractType_NameLocalizationKey_FreightContract" key, instead of "FreightContract".

Also in your scripts, I dont see localization loading logic (something that I posted above)

Hello, Patrick and other Engineers!

Thank you so much for reporting this.

This thread can be basically split to three topics:

1) the contracts do not appear in the contract blocks on economy stations

2) when contracts are placed manually in player spawned station, it is not affecting reputation

3) the localization issue

I've reported the first two issues.

The third one should be solved if you use the piece of code and information from Gregory, which you can find above.

Kind Regards

Keen Software House: QA Department

Hi Ondrej! Thank you very much for taking the time to look at this issue. Please let me know if you need any additional information from me. :)

Hello, Patrick,

so, our programmer team took a look on this thread and these issues.

They came to conclusion that only the second part bugged. I needed to close the first one (contract do not appear in the stations), as contracts on stations are only for that specific NPC faction not for players.

Still keeping this thread on Reported state though, because of the second issue (reputation not changing).

Kind Regards

Keen Software House: QA Department

Hello, I tried to implement custom contract in a simmilar manner. Contracts are being added properly to NPC contract blocks that are on NPC encounters or that are manually placed for example, but aren't added to the economy trade station contract blocs.

The steps to replicate the issue (done via MyApiGateway.ContractSystem API)

1. I created an NPC contract that belongs to an NPC faction.
2. I attempt to add that contract to an Economy station that is owned by the same NPC faction.
3. The contract is not added to the contract block.

Expected result

NPC contract owned by NPC faction is added to contract block on Economy station owned by same NPC faction.

Actual result

Contract does not appear in the contract block.

Issues with the modding API for custom contracts include missing contracts on Economy stations and reputation not changing upon completion. Workarounds involve spawning new trading stations for contracts. Additionally, contract type names show localization errors despite attempts to fix them. This resembles gaming challenges like Moto X3M tricky levels—engaging yet frustrating. Feel free to review the code if needed!