[187.2] ModAPI: SetToolbarSlotToItem causes everyone in server to disconnect

Digi shared this bug 2 years ago
Considered

Using MyVisualScriptLogicProvider.SetToolbarSlotToItem() on a client in DS makes everyone disconnect. Does not crash the server and players can rejoin immediately.


Can be replicated solo, steps:

1. Start a DS with this mod: https://steamcommunity.com/sharedfiles/filedetails/?id=1496691416

2. Join your DS.

3. After you spawn, press R key (no matter what binds you have) to cause the mod to use SetToolbarSlotToItem.

Now you should be disconnected from the server with no message (or forever paused).

Comments (3)

photo
1

Hello, Engineer!


Thank you for your feedback! Your topic has been added between considered issues.

Please keep voting for the issue as it will help us to identify the most serious bugs.


We really appreciate your patience.


Kind Regards

Keen Software House: QA Department

photo
1

This no longer disconnects but it doesn't do anything either, it's broken in MP.

photo
1

After some debugging it seems the transmitted MyDefinitionId doesn't reach the other side in a valid state, probably because it's not meant to be serialized, maybe switch to SerialziableDefinitionId?