Hardcoded limit on Global Encounter removal timers
Good day! I've noticed that settings related to Global Encounter removal timers (specifically GlobalEncounterMinRemovalTimer and GlobalEncounterMaxRemovalTimer) are limited in the range of values they can take. Attempting to set both below an hour still resulted in the encounter lasting for 90 minutes.
And so I went digging, finding that there are hardcoded limits to these values. The settings have RangeAttributes in MyObjectBuilder_SessionSettings which suggest the timers can be set between 90 and 180 minutes, however these attributes are never actually used for validation. Instead, the SpaceEngineers.Game.SessionComponents.MyGlobalEncountersGenerator.RegisterEncounter() method uses hardcoded values (the same ones as in the RangeAttributes) to clamp the settings before usage.
I have written a plugin that removes these clamps, however seeing as they are hardcoded values, I wonder if they have some purpose I never uncovered? In any case, if they can be safely removed, I would suggest their removal for the sake of configuration freedom. Especially on active servers and in scenarios where having 1 encounter at a time is preferential, the hard limit of 90 minutes minimum is quite unfortunate...
Thank you for the explanation/consideration of this adjustment!
Replies have been locked on this page!