ForbiddenTopPart should be AllowedTopPart

DontFollowOrders shared this feedback 4 days ago
Not Enough Votes

First off I would like to open this up by expressing my appreciation for your attention to the state of subgrids, as this fix--while not seemingly widely desired for vanilla type subgrid joints--brings much more potential for safely connecting modded subgrids in compacted geometry.


However there is one little tweak I would make, as the implementation sits in a bit of an odd position for us modders. You have invented this mechanic as a blacklist, where it should have been a whitelist.


if (base.MotorDefinition.ForbiddenTopPartSubtypes.Contains(rotor.BlockDefinition.Id.SubtypeId))

{

return false;

}


This requires us to list every single possible subtypeid of blocks from all mods if we intend to make our mechanical block exclusive. If you would please simply change it to:


if (!(base.MotorDefinition.AllowedTopPartSubtypes.Contains(rotor.BlockDefinition.Id.SubtypeId))

{

return false;

}


and update all associated references, all mechanical base parts would be exclusive by default, with exceptions made only intentionally, therefore no longer requiring us to generate an infinite list to future-proof our mechanical base blocks.


Thanks, and have a wonderful time!

Leave a Comment
 
Attach a file
Access denied