Ship welders don't repair weapons damage on blocks

Morpheus shared this bug 12 months ago
Solved

I am encountering what I think is technically a game breaking bug.

Using either a ship's turret or handheld weapon, I damage a block, in this case a heavy armor block untill deformation is visible.

I then grab my large grid, very simple, welding ship and atempt to weld the damaged blocks.

Welding sparks fly for a very short period, too short.

I go to check the blocks when no more sparks will fly and using the handheld welder or grinder, it is immediately evident that no damage was repaired however the damaged blocks are no longer deformed.

This is NOT an issue of build error (having more than 3000 hours I am more than familliar with proper, and intended building techniques of the game) as the build is intentionally simple with a clear path from the cargo container, through the conveyor tube, to the welder utilizing the large conveyor tubes so as to avoid the issue of certain mats being incompatible for smaller conveyor tubes; and, this also doesn't account for the removal of the block's deformation without adding mats to the block.

I have tried relogging (F5), moving the ship out of range of any other grid and returning it to the previous location, jumping the grid away and back, grinding down and rewelding by hand the ship welders, removing and replacing the ship welders, restarting the game, having other players attempt to repair the blocks in question using my welder ship, having other players grind down/remove and reweld/replace the ship welders, and verifying game files all to no effect.

Note: This issue is exclusive to weapons damage and grinding down a block with a grinder does not produce this effect. I have also confirmed the bug with multiple players on varying servers both vanilla non-experimental and modded servers.

I tried to provide every detail; if there is anything missing please let me know.

Comments (21)

photo
1

can you provide a world/blueprint file of the ships you are working with?

photo
1

I once have something similar. The s.p.a.t drone come by and damage one of the "keen blue ship" engine then being destroyed by green base. Trying to fix damage with "Keen builder ship" (all required items was in the cargo) the builder act like it was fixed even with the "help others" turned on. I owned all of that ships but it seems, that i must fix that engine by hand...

photo
1

NA Keen server #11 non-experimental

As I stated, a very basic large grid welder ship build with a straight unobstructed path from a large cargo containter, through 4 conveyor tubes, to a welder. No bp required for something that simple right? Besides, it's happening to everyone's welder ships that I have spoken to. People who thought they didn't have the bug are discovering that they indeed do have it after they check the blocks in question with a handheld welder.

DIO_SVK sounds like you have the bug, please click the "I have the same bug" button at the bottom of the report

photo
1

I just had an incident where I jumped a large grid into a static grid due to an, as-of-yet untraceable bug.... however in the aftermath I found I was unable to repair the blocks... I had to grind them down a little first then repair in order to get rid of the damage effects and return the block to functional status. Simply repairing with the welder did nothing.

photo
1

Hello,

I am unable to reproduce it. Any additional information would be greatly appreciated! (world, blueprint or video would be great as well.)


Thank you.

Kind Regards

Keen Software House: QA Department

photo
1

reproduction steps:

  1. Go into SP survival
  2. Enable creative tools
  3. spawn a cockpit and a block on top of the cockpit - convert to station
  4. spawn a small ship with a gatling gun, cargo with attached welder
  5. put uranium in the reactor, put nato ammo in the gatling gun, put steel plates and metal grids into the cargo
  6. turn off creative tools
  7. shoot the block with the gatling gun
  8. attempt to repair it with the ship welder - note it fixes deformation but does not replace components in the damaged armor block (if you put materials directly into the welder it works fine)
  9. tap a grinder on the damaged block
  10. attempt repair again with ship welder - note it repairs

After comparing the save at all different stages in this I observed the following.

  • After tapping the weapon damaged armor block with a hand held grinder a new XML element appears "<BuildPercent>0.9159022</BuildPercent>"
  • Manually editing the SBS file after weapons damage and placing the <BuildPercent>0.9159022</BuildPercent> back into the cube block, saving and deleting the SBSB1 file I could immediately weld with the ship welder.

The buildpercent XML node is critical, for some reason, to the block being able to be welded by ship welders.


NO SHIP WELDING:

<MyObjectBuilder_CubeBlock xsi:type="MyObjectBuilder_CubeBlock">

<SubtypeName>LargeHeavyBlockArmorBlock</SubtypeName>

<IntegrityPercent>0.413636357</IntegrityPercent>

<ColorMaskHSV x="0" y="-0.8" z="0" />

<ConstructionStockpile>

<Items xsi:type="MyObjectBuilder_StockpileItem">

<Amount>1712</Amount>

<PhysicalContent xsi:type="MyObjectBuilder_Ore">

<SubtypeName>Scrap</SubtypeName>

</PhysicalContent>

</Items>

<Items xsi:type="MyObjectBuilder_StockpileItem">

<Amount>15</Amount>

<PhysicalContent xsi:type="MyObjectBuilder_Component">

<SubtypeName>SteelPlate</SubtypeName>

</PhysicalContent>

</Items>

</ConstructionStockpile>

<BuiltBy>144115188075855897</BuiltBy>

</MyObjectBuilder_CubeBlock>


SHIP WELDING WORKS

<MyObjectBuilder_CubeBlock xsi:type="MyObjectBuilder_CubeBlock">

<SubtypeName>LargeHeavyBlockArmorBlock</SubtypeName>

<IntegrityPercent>0.413636357</IntegrityPercent>

<BuildPercent>0.9159022</BuildPercent>

<ColorMaskHSV x="0" y="-0.8" z="0" />

<ConstructionStockpile>

<Items xsi:type="MyObjectBuilder_StockpileItem">

<Amount>1712</Amount>

<PhysicalContent xsi:type="MyObjectBuilder_Ore">

<SubtypeName>Scrap</SubtypeName>

</PhysicalContent>

</Items>

<Items xsi:type="MyObjectBuilder_StockpileItem">

<Amount>15</Amount>

<PhysicalContent xsi:type="MyObjectBuilder_Component">

<SubtypeName>SteelPlate</SubtypeName>

</PhysicalContent>

</Items>

</ConstructionStockpile>

<BuiltBy>144115188075855897</BuiltBy>

</MyObjectBuilder_CubeBlock>

photo
photo
1

I just reproduced this in a survival world. Reversed it, and reproduced again.

What I did and observed:

Enable Creative tools

Place a wall of heavy armour blocks

Paste in a welder toolship (I used a small grid one)

Place steel plates and metal grids into a correctly conveyored cargo container in the ship (not the welders)

Disable creative tools mode.

Shoot the heavy armour until multiple adjacent blocks are all below their 'functional' line.

Use the ship (via mouseclick, not toggle welders on) to try to repair the damage: Behaviour as described (welders flicker, the deformation disappears, but repair level does not increase nor parts consumed)

Transfer steel plates and metal grids to the welders inventory by hand in the inventory window (and check terminal to verify that use conveyors is on).

Welding now works.

photo
1

Video as requested. Everything in the video is as I have described. I used the yellow respawn ship, ground down some parts so I could make it into a basic welder ship without major modifications. I don't know how I can elaborate further.

photo
1

Video as requested. Everything in the video is as I have described. I used the yellow respawn ship, ground down some parts so I could make it into a basic welder ship without major modifications. I don't know how I can elaborate further. Baur from the Torch Community believes this is an issue with scrap metal filling the weapon damaged blocks where they then prevent any mats from transferring into the blocks.

photo
1

Something is up with this forum. I am unable to upload the 436 Mb mp4 video so I have posted a link to my YouTube channel https://www.youtube.com/watch?v=ZTkV8GlHr28&t=92s Everything in the video is as I have described. I used the yellow respawn ship, ground down some parts so I could make it into a basic welder ship without major modifications. I don't know how I can elaborate further. Baur from the Torch Community believes this is an issue with scrap metal filling the weapon damaged blocks where they then prevent any mats from transferring into the blocks.

photo
1

I also can confirm this.

photo
1

Sorry about the repeat posts, like I said something wasn't going right while trying to upload the video

photo
1

I was able to reproduce in SP, survival, DISABLE CREATIVE TOOLS, without issue. I can also confirm placing the parts directly in the welder allows the correct repair to occur.

photo
1

This is a very old bug apparently. Same issue with the scrap metal.


https://forum.keenswh.com/threads/01-102-110-welders-dont-pull-components-to-repair.7369556/

photo
1

Wow, this is surprising

photo
1

Just google "welders not repairing damage blocks"

There are tons of responses to this exact issue.

photo
1

Bump! All available information has been provided.

photo
1

Same, my damaged ships are not being properly repaired by welder ships or station welders.

To circumvent this i have to grind the damaged block for 1 second and then it gets fully repaired as it should, this is specially true with self repairing turrets on stations with a welder nearby, they dont repair the dmg unless i grind the turrent for 1 second, and then it works.


its like the welders identify the block as 'under construction' stage so it can work properly

photo
1

Just experienced this on [1.188.105] as well. Like previous posts, seems I'm having issues repairing battle damage from enemy weapons with ship welders as well. Usage of the hand welder or grinding the affected blocks by any means (hand or ship) for a second seems to work around the issue.

I found this post from the legacy support forum interesting regarding the block not repairing because it contains scrap metal that needs to be extracted first. After testing with a save over and over and closely monitoring all inventories (including the player's) for the presence of scrap metal before, during, and after repair, I'm inclined to agree this is the problem. The ship welders seem to be only one-way in that the scrap metal can't come back out of the damaged block. The hand welder, however, both extracts the scrap metal and inserts the necessary components for a repair. This explains why grinding the blocks for a second is also a workaround since they pull components out of blocks by design, including the scrap metal choking the attempted repair in this case.

There's a few solutions I see:

  • Eliminate scrap metal being inside damaged blocks.
  • Allow ship welders to pull scrap metal, and only scrap metal, from blocks if it's present to allow for a successful intuitive repair.
  • Add scrap metal as a currently "installed" component when viewing the block so the player at least knows what is going on. (Not ideal solution at all since this could still be easily missed if using ship welders, which is the whole problem to begin with.)

photo
1

This bug has just moved to "in progress," but I'll add that the issue is not limited to battle damage. It's any damaged block that contains scrap metal. I just bumped into a hydrogen thruster in my welder small ship and it's now on fire. I have plenty of components in the welder ship but was unable to repair the thruster.

Even after posting in this thread, I was puzzled for a moment. I soon jumped out of the welder ship, grinded the thruster for a split second, extracted the necessary scrap metal into my personal inventory, and welded/repaired the thruster with the small ship welder. I could have also used the grinder on my welder ship to do the same, but was afraid of grinding other nearby blocks too much in this case.