DefenseShields Bug (Will affect any damage preventing mod)

Shane Stixrud shared this bug 4 months ago
Solved

With the new update RegisterBeforeDamageHandler can no longer be used to set info.Amount = 0. This prevents any mod like mine from preventing damage. This is pretty much game over for a mod like mine, so I sure hope this can be fixed. I have attached a 15 line script that illustrates the issue.

Comments (12)

photo
3

For anyone he is interested here is the script to reproduce the bug:


https://paste.ofcode.org/QadGbm3wSxWEjVdNaNTwyM

photo
1

Please fix this Keen, it would be a shame to see a mod like this go down the drain. It is one of the best mods I believe!

photo
1

Mods like this are perfect for the people who like a bit of pve combat but dont want their ship/base destroyed or badly damaged, really hope this gets fixed

photo
1

Yes keen please fix, The lord of the dead would not like his god ship to become a mortal ship.

NOO!!! my identity is revealed!

photo
1

This bug breaks a number of other mods as well, including the popular Energy Shields mod and some invulnerable admin-block mods. Keen please fix this :( <3

photo
1

Please fix this!

photo
1

This is one of the best mods out there and I would hate to see it continue to not function as before. Please fix this Keen!

photo
1

Oh my, there mods were a MUST! I actually came across the bug right now. This is game breaking for me, I hate to have amazing mods like this go away. Most of my ship builds are built relying on these shields. Too bad. Hopefully These guys can fix it soon

photo
3

@Equinox found what the change and issue is it seems:


MyDamageInformation info = new MyDamageInformation(false, damage, damageType, attackerId);

if (this.UseDamageSystem)

{

MyDamageSystem.Static.RaiseBeforeDamageApplied(this, ref info);

}

this.AccumulatedDamage += damage;


after RaiseBeforeDamageApplied damage = info.Damage should be written

photo
8

This will be fixed in hotfix 1.187.088

photo
1

Awesome!

photo
photo
2

Great to hear Chuck!